Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

replacing eval()s to avoid 'eval injection' and improve HHVM Repo Author... #8

Merged
merged 3 commits into from
Jun 1, 2015
Merged

replacing eval()s to avoid 'eval injection' and improve HHVM Repo Author... #8

merged 3 commits into from
Jun 1, 2015

Conversation

colin-kiegel
Copy link
Contributor

...itative compatibility

@colin-kiegel
Copy link
Contributor Author

again I performed extra tests, which can be found here: https://gist.github.com/colin-kiegel/b8e1ba2c1a1c414c4379

@chfsx
Copy link
Member

chfsx commented Mar 24, 2015

Hi Colin. PHPlot is an external library, I'm not sure whether we should make changes here...

@Amstutz
Copy link
Contributor

Amstutz commented Mar 24, 2015

I agree with Fabian. Since since the development on Phplot seems still active, you should make the request there. To keep our dependencies clean (patch free) we should always try to play our fixes in external libraries back to the repo of the library itself. I think your changes have good chances to be accepted there.

Since the version of Phplot is of 2008-01-13, we should check to update to a current version anyways, which might already solve the problem.

@chfsx: We should think about a proper way of including external libraries as submodule (or similar) to have a cleaner build an proper relations with our dependencies in future.

@colin-kiegel
Copy link
Contributor Author

ok, I agree - phplot seems actively maintained. I will proposed it upstream (https://sourceforge.net/p/phplot/bugs/170/). However it might take 'a while' until this will (a) be accepted there (b) released officially and (c) integrated in ILIAS.

The other two libraries PEAR and math eval don't seem to be actively maintained. I think it would be ok to include these really small changes left.

@alex40724
Copy link
Member

If patches of third party libs are necessary, this must be documented. See e.g. Services/PEAR/lib/ReleaseInfo.php

@colin-kiegel
Copy link
Contributor Author

done - class.MathEval.php didn't have a ReleaseInfo, so I created one.

@alex40724
Copy link
Member

Björn, since you rely on MathEval I leave it to you to merge this one if you accept it. For me the PEAR patch is ok.

@chfsx
Copy link
Member

chfsx commented Jun 1, 2015

+1 for merging if possible for you @bheyser

bheyser pushed a commit that referenced this pull request Jun 1, 2015
Merge pull request #8 from colin-kiegel/trunk_evals_replaced
9178101 
replacing eval()s to avoid 'eval injection' and improve HHVM Repo Author...

yes, eval replace in ilMath is great idea, I wonder why call_user_func wasn't used there.
@bheyser bheyser merged commit 9178101 into ILIAS-eLearning:trunk Jun 1, 2015
bheyser pushed a commit to ILIAS-Verein/IIC50 that referenced this pull request Aug 21, 2015
lok3 ILIAS-eLearning#8
7d3f424
klees referenced this pull request in klees/ILIAS Oct 22, 2015
@klees
Merge pull request #8 from klees/4_4_seepex
40b8f50 
SPX: ILIAS-eLearning#1741, ILIAS-eLearning#1721
klees added a commit that referenced this pull request Jul 27, 2016
@klees
Merge pull request #8 from dkloepfer/trunk_gui
02fcc66 
rule about kitchen sink info block encapsulation
tomaszkolonko pushed a commit to tomaszkolonko/ILIAS that referenced this pull request Aug 22, 2016
@Amstutz
Merge pull request ILIAS-eLearning#8 from tomaszkolonko/trunk_gui_tz
cbdd80c 
Trunk gui tz
nhaagen referenced this pull request in nhaagen/ILIAS Jan 19, 2018
@catkrahl
Merge pull request #8 from nhaagen/UI_PageLayoutRevision
4d6e197 
Navigate back in slate
@nmatuschek nmatuschek mentioned this pull request Mar 5, 2020
Merged
KamuiXenom added a commit to KamuiXenom/ILIAS that referenced this pull request Mar 23, 2020
@KamuiXenom
Fix ilCronManager::runJob:95 count(): Parameter must be an array or a…
a06a385 
…n object that implements Countable

Fixing error by using ldap-user-sync.

replace debug message after checking for an array

ERROR-LOG:

ilCronManager::runJob:95 count(): Parameter must be an array or an object that implements Countable
ilCronManager::runJob:95 #0 ILIAS_PATH/Services/Init/classes/class.ilErrorHandling.php(461): Whoops\Run->handleError(2, 'count(): Parame...', 'ILIAS_PATH...', 387)
ILIAS-eLearning#1 ILIAS_PATH/Services/LDAP/classes/class.ilLDAPQuery.php(387): ilErrorHandling->handlePreWhoops(2, 'count(): Parame...', 'ILIAS_PATH...', 387, Array)
ILIAS-eLearning#2 ILIAS_PATH/Services/LDAP/classes/class.ilLDAPQuery.php(131): ilLDAPQuery->fetchGroupMembers()
ILIAS-eLearning#3 ILIAS_PATH/Services/LDAP/classes/class.ilLDAPCronSynchronization.php(87): ilLDAPQuery->fetchUsers()
ILIAS-eLearning#4 ILIAS_PATH/Services/Cron/classes/class.ilCronManager.php(178): ilLDAPCronSynchronization->run()
ILIAS-eLearning#5 ILIAS_PATH/Services/Cron/classes/class.ilCronManager.php(95): ilCronManager::runJob(Object(ilLDAPCronSynchronization), Array, true)
ILIAS-eLearning#6 ILIAS_PATH/Services/Cron/classes/class.ilCronManagerGUI.php(282): ilCronManager::runJobManual('ldap_sync')
ILIAS-eLearning#7 ILIAS_PATH/Services/Cron/classes/class.ilCronManagerGUI.php(64): ilCronManagerGUI->confirmedRun()
ILIAS-eLearning#8 ILIAS_PATH/Services/UICore/classes/class.ilCtrl.php(210): ilCronManagerGUI->executeCommand()
ILIAS-eLearning#9 ILIAS_PATH/Modules/SystemFolder/classes/class.ilObjSystemFolderGUI.php(152): ilCtrl->forwardCommand(Object(ilCronManagerGUI))
ILIAS-eLearning#10 ILIAS_PATH/Services/UICore/classes/class.ilCtrl.php(210): ilObjSystemFolderGUI->executeCommand()
ILIAS-eLearning#11 ILIAS_PATH/Services/Administration/classes/class.ilAdministrationGUI.php(250): ilCtrl->forwardCommand(Object(ilObjSystemFolderGUI))
ILIAS-eLearning#12 ILIAS_PATH/Services/UICore/classes/class.ilCtrl.php(210): ilAdministrationGUI->executeCommand()
ILIAS-eLearning#13 ILIAS_PATH/Services/UICore/classes/class.ilCtrl.php(175): ilCtrl->forwardCommand(Object(ilAdministrationGUI))
ILIAS-eLearning#14 ILIAS_PATH/ilias.php(20): ilCtrl->callBaseClass()
ILIAS-eLearning#15 {main}
@KamuiXenom KamuiXenom mentioned this pull request Mar 23, 2020
Merged
Amstutz added a commit that referenced this pull request Mar 22, 2021
@Amstutz
Merge pull request #8 from ezenzen/css_squad_branch_zenzen_II
4117dee 
General Variables- and Accessibility-Fixes 2.2_focus-mixin
utesche pushed a commit to utesche/ILIAS that referenced this pull request Nov 16, 2021
var $retypeavalue needs initialization
14cf688 
When logging in as root for the very first time, the dialog for the mandatory password change is about to shown - but ends up in a sequence of 10 similar execeptions, each complaining about the same issue:

[978n6] [2021-11-16 10:43:11.379261] trunk8_root.ERROR: Whoops\Handler\CallbackHandler::handle:370 0 Typed property ilPasswordInputGUI::$retypevalue must not be accessed before initialization in /***/trunk8/Services/Form/classes/class.ilPasswordInputGUI.php:77#0 /***/trunk8/Services/Form/classes/class.ilPasswordInputGUI.php(245): ilPasswordInputGUI->getRetypeValue()
#1 /***/trunk8/Services/Form/classes/class.ilPasswordInputGUI.php(287): ilPasswordInputGUI->render()
#2 /***/trunk8/Services/Form/classes/class.ilPropertyFormGUI.php(665): ilPasswordInputGUI->insert()
#3 /***/trunk8/Services/Form/classes/class.ilPropertyFormGUI.php(560): ilPropertyFormGUI->insertItem()
ILIAS-eLearning#4 /***/trunk8/Services/Form/classes/class.ilFormGUI.php(126): ilPropertyFormGUI->getContent()
ILIAS-eLearning#5 /***/trunk8/Services/Form/classes/class.ilPropertyFormGUI.php(798): ilFormGUI->getHTML()
ILIAS-eLearning#6 /***/trunk8/Services/User/Settings/classes/class.ilPersonalSettingsGUI.php(197): ilPropertyFormGUI->getHTML()
ILIAS-eLearning#7 /***/trunk8/Services/User/Settings/classes/class.ilPersonalSettingsGUI.php(79): ilPersonalSettingsGUI->showPassword()
ILIAS-eLearning#8 /***/trunk8/Services/UICore/classes/class.ilCtrl.php(215): ilPersonalSettingsGUI->executeCommand()
ILIAS-eLearning#9 /***/trunk8/Services/Dashboard/classes/class.ilDashboardGUI.php(122): ilCtrl->forwardCommand()
ILIAS-eLearning#10 /***/trunk8/Services/UICore/classes/class.ilCtrl.php(215): ilDashboardGUI->executeCommand()
ILIAS-eLearning#11 /***/trunk8/Services/UICore/classes/class.ilCtrl.php(176): ilCtrl->forwardCommand()
ILIAS-eLearning#12 /***/trunk8/ilias.php(19): ilCtrl->callBaseClass()
ILIAS-eLearning#13 {main}
@utesche utesche mentioned this pull request Nov 16, 2021
Closed
utesche pushed a commit to utesche/ILIAS that referenced this pull request May 19, 2022
bugfix: ilObjOrgUnitTree::$temporary_table_name needs initialization
af3d328 
when requesting "Profile and Privacy" from metabar menu, the following error is thrown:

Error thrown with message "Typed static property ilObjOrgUnitTree::$temporary_table_name must not be accessed before initialization"
Stacktrace:
ILIAS-eLearning#12 Error in /srv/www/xyz/Modules/OrgUnit/classes/class.ilObjOrgUnitTree.php:375
ILIAS-eLearning#11 ilObjOrgUnitTree:buildTempTableWithUsrAssignements in /srv/www/xyz/Modules/OrgUnit/classes/PathStorage/class.ilOrgUnitPathStorage.php:77
ILIAS-eLearning#10 ilOrgUnitPathStorage:getTextRepresentationOfUsersOrgUnits in /srv/www/xyz/Services/User/classes/class.ilObjUser.php:2586
ILIAS-eLearning#9 ilObjUser:lookupOrgUnitsRepresentation in /srv/www/xyz/Services/User/classes/class.ilObjUser.php:2591
ILIAS-eLearning#8 ilObjUser:getOrgUnitsRepresentation in /srv/www/xyz/Services/User/classes/class.ilUserProfile.php:785
ILIAS-eLearning#7 ilUserProfile:addStandardFieldsToForm in /srv/www/xyz/Services/User/Profile/classes/class.ilPersonalProfileGUI.php:632
ILIAS-eLearning#6 ilPersonalProfileGUI:initPersonalDataForm in /srv/www/xyz/Services/User/Profile/classes/class.ilPersonalProfileGUI.php:582
ILIAS-eLearning#5 ilPersonalProfileGUI:showPersonalData in /srv/www/xyz/Services/User/Profile/classes/class.ilPersonalProfileGUI.php:122
ILIAS-eLearning#4 ilPersonalProfileGUI:executeCommand in /srv/www/xyz/Services/UICore/classes/class.ilCtrl.php:178
#3 ilCtrl:forwardCommand in /srv/www/xyz/Services/Dashboard/classes/class.ilDashboardGUI.php:107
#2 ilDashboardGUI:executeCommand in /srv/www/xyz/Services/UICore/classes/class.ilCtrl.php:178
#1 ilCtrl:forwardCommand in /srv/www/xyz/Services/UICore/classes/class.ilCtrl.php:153
#0 ilCtrl:callBaseClass in /srv/www/xyz/ilias.php:24
@utesche utesche mentioned this pull request May 19, 2022
Closed
utesche pushed a commit to utesche/ILIAS that referenced this pull request Jul 18, 2022
bugfix: $controls may not be NULL when calling ldap_search()
32917ae 
otherwise a TypeError Exception is raised:

TypeError thrown with message "ldap_search() expects parameter 9 to be array, null given"

Stacktrace:
ILIAS-eLearning#10 TypeError in /.../Services/LDAP/classes/class.ilLDAPQuery.php:520
ILIAS-eLearning#9 ldap_search in /.../Services/LDAP/classes/class.ilLDAPQuery.php:520
ILIAS-eLearning#8 ilLDAPQuery:queryByScope in /.../Services/LDAP/classes/class.ilLDAPQuery.php:474
ILIAS-eLearning#7 ilLDAPQuery:readUserData in /.../Services/LDAP/classes/class.ilLDAPQuery.php:87
ILIAS-eLearning#6 ilLDAPQuery:fetchUser in /.../Services/LDAP/classes/class.ilAuthProviderLDAP.php:58
@utesche utesche mentioned this pull request Jul 18, 2022
Closed
fhelfer referenced this pull request in fhelfer/ILIAS May 8, 2023
@fhelfer
review dashboard #8
a7a809e
fhelfer referenced this pull request in fhelfer/ILIAS May 25, 2023
@fhelfer
review dashboard #8
dcacf40
fhelfer referenced this pull request in fhelfer/ILIAS Jun 22, 2023
@fhelfer
review dashboard #8
da6fb57
fhelfer referenced this pull request in fhelfer/ILIAS Jun 26, 2023
@fhelfer
review dashboard #8
d5eecb9
This was referenced Sep 11, 2023
Merged
Merged
eozkeskin added a commit to eozkeskin/ILIAS that referenced this pull request Apr 22, 2024
@eozkeskin
Fix: Type error. ilObjSurvey::getAnonymousIdByCode()
bc467b3 
TypeError thrown with message "Return value of ilObjSurvey::getAnonymousIdByCode() must be of the type int, null returned"

Stacktrace:
ILIAS-eLearning#9 TypeError in /var/www/html/Modules/Survey/classes/class.ilObjSurvey.php:4702
ILIAS-eLearning#8 ilObjSurvey:getAnonymousIdByCode in /var/www/html/Modules/Survey/Execution/class.ilSurveyExecutionGUI.php:175
ILIAS-eLearning#7 ilSurveyExecutionGUI:checkAuth in /var/www/html/Modules/Survey/Execution/class.ilSurveyExecutionGUI.php:354
ILIAS-eLearning#6 ilSurveyExecutionGUI:outSurveyPage in /var/www/html/Modules/Survey/Execution/class.ilSurveyExecutionGUI.php:280
ILIAS-eLearning#5 ilSurveyExecutionGUI:redirectQuestion in /var/www/html/Modules/Survey/Execution/class.ilSurveyExecutionGUI.php:140
ILIAS-eLearning#4 ilSurveyExecutionGUI:executeCommand in /var/www/html/Services/UICore/classes/class.ilCtrl.php:199
ILIAS-eLearning#3 ilCtrl:forwardCommand in /var/www/html/Modules/Survey/classes/class.ilObjSurveyGUI.php:206
ILIAS-eLearning#2 ilObjSurveyGUI:executeCommand in /var/www/html/Services/UICore/classes/class.ilCtrl.php:199
#1 ilCtrl:forwardCommand in /var/www/html/Services/UICore/classes/class.ilCtrl.php:174
#0 ilCtrl:callBaseClass in /var/www/html/ilias.php:24
alex40724 pushed a commit that referenced this pull request Apr 22, 2024
@eozkeskin
Fix: Type error. ilObjSurvey::getAnonymousIdByCode() (#7410)
31a934a 
TypeError thrown with message "Return value of ilObjSurvey::getAnonymousIdByCode() must be of the type int, null returned"

Stacktrace:
#9 TypeError in /var/www/html/Modules/Survey/classes/class.ilObjSurvey.php:4702
#8 ilObjSurvey:getAnonymousIdByCode in /var/www/html/Modules/Survey/Execution/class.ilSurveyExecutionGUI.php:175
#7 ilSurveyExecutionGUI:checkAuth in /var/www/html/Modules/Survey/Execution/class.ilSurveyExecutionGUI.php:354
#6 ilSurveyExecutionGUI:outSurveyPage in /var/www/html/Modules/Survey/Execution/class.ilSurveyExecutionGUI.php:280
#5 ilSurveyExecutionGUI:redirectQuestion in /var/www/html/Modules/Survey/Execution/class.ilSurveyExecutionGUI.php:140
#4 ilSurveyExecutionGUI:executeCommand in /var/www/html/Services/UICore/classes/class.ilCtrl.php:199
#3 ilCtrl:forwardCommand in /var/www/html/Modules/Survey/classes/class.ilObjSurveyGUI.php:206
#2 ilObjSurveyGUI:executeCommand in /var/www/html/Services/UICore/classes/class.ilCtrl.php:199
#1 ilCtrl:forwardCommand in /var/www/html/Services/UICore/classes/class.ilCtrl.php:174
#0 ilCtrl:callBaseClass in /var/www/html/ilias.php:24
alex40724 added a commit that referenced this pull request Apr 22, 2024
@alex40724
Fix: Type error. ilObjSurvey::getAnonymousIdByCode() (#7410)
b5648ea 
TypeError thrown with message "Return value of ilObjSurvey::getAnonymousIdByCode() must be of the type int, null returned"

Stacktrace:
#9 TypeError in /var/www/html/Modules/Survey/classes/class.ilObjSurvey.php:4702
#8 ilObjSurvey:getAnonymousIdByCode in /var/www/html/Modules/Survey/Execution/class.ilSurveyExecutionGUI.php:175
#7 ilSurveyExecutionGUI:checkAuth in /var/www/html/Modules/Survey/Execution/class.ilSurveyExecutionGUI.php:354
#6 ilSurveyExecutionGUI:outSurveyPage in /var/www/html/Modules/Survey/Execution/class.ilSurveyExecutionGUI.php:280
#5 ilSurveyExecutionGUI:redirectQuestion in /var/www/html/Modules/Survey/Execution/class.ilSurveyExecutionGUI.php:140
#4 ilSurveyExecutionGUI:executeCommand in /var/www/html/Services/UICore/classes/class.ilCtrl.php:199
#3 ilCtrl:forwardCommand in /var/www/html/Modules/Survey/classes/class.ilObjSurveyGUI.php:206
#2 ilObjSurveyGUI:executeCommand in /var/www/html/Services/UICore/classes/class.ilCtrl.php:199
#1 ilCtrl:forwardCommand in /var/www/html/Services/UICore/classes/class.ilCtrl.php:174
#0 ilCtrl:callBaseClass in /var/www/html/ilias.php:24
alex40724 added a commit that referenced this pull request Apr 22, 2024
@alex40724
Fix: Type error. ilObjSurvey::getAnonymousIdByCode() (#7410)
958f5ee 
TypeError thrown with message "Return value of ilObjSurvey::getAnonymousIdByCode() must be of the type int, null returned"

Stacktrace:
#9 TypeError in /var/www/html/Modules/Survey/classes/class.ilObjSurvey.php:4702
#8 ilObjSurvey:getAnonymousIdByCode in /var/www/html/Modules/Survey/Execution/class.ilSurveyExecutionGUI.php:175
#7 ilSurveyExecutionGUI:checkAuth in /var/www/html/Modules/Survey/Execution/class.ilSurveyExecutionGUI.php:354
#6 ilSurveyExecutionGUI:outSurveyPage in /var/www/html/Modules/Survey/Execution/class.ilSurveyExecutionGUI.php:280
#5 ilSurveyExecutionGUI:redirectQuestion in /var/www/html/Modules/Survey/Execution/class.ilSurveyExecutionGUI.php:140
#4 ilSurveyExecutionGUI:executeCommand in /var/www/html/Services/UICore/classes/class.ilCtrl.php:199
#3 ilCtrl:forwardCommand in /var/www/html/Modules/Survey/classes/class.ilObjSurveyGUI.php:206
#2 ilObjSurveyGUI:executeCommand in /var/www/html/Services/UICore/classes/class.ilCtrl.php:199
#1 ilCtrl:forwardCommand in /var/www/html/Services/UICore/classes/class.ilCtrl.php:174
#0 ilCtrl:callBaseClass in /var/www/html/ilias.php:24
@fhelfer fhelfer mentioned this pull request Jun 5, 2024
Merged
@dsstrassner dsstrassner mentioned this pull request Jun 17, 2024
Merged
thojou pushed a commit to thojou/ILIAS that referenced this pull request Dec 11, 2024
@lscharmer
Merge branch 'soap-improvements' into 'release_9'
6cc1003 
soap-improvements

Closes ILIAS-eLearning#8

See merge request ilias-hosting/ilias!11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@bheyser bheyser

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@colin-kiegel @chfsx @Amstutz @alex40724 @bheyser